feat!: Yolo object detection by benITo47 · Pull Request #987 · software-mansion/react-native-executorch

benITo47 · 2026-03-20T10:07:24Z

Description

This PR adds yolo models and multi-method support to our ObjectDetection API.
Deduplication of common CV code will be done in a separate PR

Introduces a breaking change?

Yes
No

Type of change

Bug fix (change which fixes an issue)
New feature (change which adds functionality)
Documentation update (improves or adds clarity to existing documentation)
Other (chores, tests, code style improvements etc.)

Tested on

iOS
Android

Testing instructions

Try running example apps with Yolo models
Run tests

Screenshots

Related issues

Closes #718

Checklist

I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly
My changes generate no new warnings

Additional notes

...ages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp

packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts

docs/docs/02-benchmarks/memory-usage.md

apps/computer-vision/app/object_detection/index.tsx

docs/docs/02-benchmarks/inference-time.md

msluszniak · 2026-03-23T20:03:04Z

Documentation CI fails because this PR needs to be committed: #1000. I will also add benchmarks for iOS. Other than that, please review this PR.

NorbertKlockiewicz

Code looks okay, I ran it on ios and android and it worked as expected, I think we could write some tests for a new parts of object detection API.

packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts

NorbertKlockiewicz

LGTM!

docs/docs/02-benchmarks/inference-time.md

…ject_detection/ObjectDetection.cpp

Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>

...ages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp

docs/docs/03-hooks/02-computer-vision/useObjectDetection.md

packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts

docs/docs/03-hooks/02-computer-vision/useObjectDetection.md

...ages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp

packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts

…ject_detection/ObjectDetection.cpp

chmjkb

I'll test the demo apps and once I finish i think its ready to 🚢

chmjkb

Two more example app issues - I don't see any bounding boxes in the vision camera demo app. The normal object detection screen works just fine, besides this styling issue which we really need to fix, otherwise I'll go bald trying to click the run model button 😆(you can see it's covered by the navbar), and its not even clickable after i click on the model selector

IMG_9614.MOV

chmjkb

The demo app works now, and the dropdown looks better, buf still using one+ 12 i see the navbar covering the run model button

chmjkb

msluszniak added the feature PRs that implement a new feature label Mar 20, 2026

benITo47 force-pushed the @bo/yoloObjectDetection branch from aec863e to 9b77da7 Compare March 20, 2026 13:46

msluszniak self-assigned this Mar 23, 2026

msluszniak reviewed Mar 23, 2026

View reviewed changes

...ages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp Outdated Show resolved Hide resolved

msluszniak reviewed Mar 23, 2026

View reviewed changes

...ages/react-native-executorch/common/rnexecutorch/models/object_detection/ObjectDetection.cpp Outdated Show resolved Hide resolved

msluszniak changed the title ~~@bo/yolo object detection~~ feat!: Yolo object detection Mar 23, 2026

msluszniak reviewed Mar 23, 2026

View reviewed changes

msluszniak marked this pull request as ready for review March 23, 2026 10:04

msluszniak requested review from NorbertKlockiewicz and chmjkb March 23, 2026 20:03

NorbertKlockiewicz reviewed Mar 24, 2026

View reviewed changes

packages/react-native-executorch/src/modules/computer_vision/ObjectDetectionModule.ts Show resolved Hide resolved

msluszniak force-pushed the @bo/yoloObjectDetection branch from 94d1c1b to 61d9548 Compare March 24, 2026 11:38

msluszniak requested a review from NorbertKlockiewicz March 24, 2026 12:26

NorbertKlockiewicz approved these changes Mar 24, 2026

View reviewed changes

msluszniak reviewed Mar 24, 2026

View reviewed changes

docs/docs/02-benchmarks/inference-time.md Show resolved Hide resolved

benITo47 and others added 11 commits March 24, 2026 16:08

feat: Add multimethod handling to ObjectDetection

5b6aa84

Update docs

c1925bf

Fix type signatures after rebase

57c44a9

Fix inproper rebase merge

77e44cf

Update packages/react-native-executorch/common/rnexecutorch/models/ob…

eb3efb1

…ject_detection/ObjectDetection.cpp

Update packages/react-native-executorch/common/rnexecutorch/models/ob…

8afe206

…ject_detection/ObjectDetection.cpp

chore close brakets

3f2a192

Apply suggestions from code review

d6c96b9

Co-authored-by: Mateusz Sluszniak <56299341+msluszniak@users.noreply.github.com>

docs: Add benchmark results for android

1c14283

chore: address suggestions from code review

a1cba0d

docs: add missing benchmarks

7a0e899

msluszniak force-pushed the @bo/yoloObjectDetection branch from 2d33d1d to 7a0e899 Compare March 24, 2026 15:09

chmjkb requested changes Mar 24, 2026

View reviewed changes

msluszniak reviewed Mar 24, 2026

View reviewed changes

msluszniak and others added 2 commits March 24, 2026 19:45

Update packages/react-native-executorch/common/rnexecutorch/models/ob…

82578d1

…ject_detection/ObjectDetection.cpp

chore: Add suggestions from code review

0b031b9

msluszniak requested a review from chmjkb March 24, 2026 18:57

chmjkb reviewed Mar 24, 2026

View reviewed changes

chmjkb requested changes Mar 24, 2026

View reviewed changes

chore: address review comments

9b3de98

msluszniak requested a review from chmjkb March 24, 2026 20:44

chmjkb requested changes Mar 25, 2026

View reviewed changes

msluszniak added 2 commits March 25, 2026 10:03

chore: add fix for android overlap of button and navbar

142f832

chore: fix llm examples on android

3c11987

chmjkb approved these changes Mar 25, 2026

View reviewed changes

msluszniak merged commit e3f886d into main Mar 25, 2026
5 checks passed

msluszniak deleted the @bo/yoloObjectDetection branch March 25, 2026 10:08

Conversation

benITo47 commented Mar 20, 2026 • edited by msluszniak Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Introduces a breaking change?

Type of change

Tested on

Testing instructions

Screenshots

Related issues

Checklist

Additional notes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msluszniak commented Mar 23, 2026

Uh oh!

NorbertKlockiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NorbertKlockiewicz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chmjkb left a comment

Choose a reason for hiding this comment

Uh oh!

chmjkb left a comment

Choose a reason for hiding this comment

Uh oh!

chmjkb left a comment

Choose a reason for hiding this comment

Uh oh!

chmjkb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benITo47 commented Mar 20, 2026 •

edited by msluszniak

Loading